Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-enable test coverage on Windows #1391

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

fix: re-enable test coverage on Windows #1391

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
79b384a
fix: re-enable test coverage
achingbrain Feb 20, 2023
cbe463b
test: test on lts and current
achingbrain Jun 10, 2023
3c37832
chore: update c8
achingbrain Jun 15, 2023
ba3ef52
Merge branch 'master' into fix/re-enable-test-coverage
achingbrain Jul 26, 2023
9371e61
Merge branch 'master' into fix/re-enable-test-coverage
achingbrain Oct 24, 2023
70369dc
Apply suggestions from code review
achingbrain Oct 24, 2023
72e7997
Merge branch 'master' into fix/re-enable-test-coverage
achingbrain Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/cmds/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import os from 'os'

Check failure on line 1 in src/cmds/test.js

View workflow job for this annotation

GitHub Actions / js-test-and-release / check 

'os' is declared but its value is never read.
import kleur from 'kleur'

Check failure on line 2 in src/cmds/test.js

View workflow job for this annotation

GitHub Actions / js-test-and-release / check 

'kleur' is declared but its value is never read.
import { loadUserConfig } from '../config/user.js'
import testCmd from '../test/index.js'

Expand Down Expand Up @@ -113,13 +113,6 @@
* @param {any} argv
*/
async handler (argv) {
// temporarily disable code coverage on Windows
if (argv.cov && os.platform() === 'win32') {
console.warn(kleur.red('!!! Temporarily disabling code coverage\n')) // eslint-disable-line no-console
console.warn(kleur.red('!!! See https://github.com/ipfs/aegir/issues/1206 for more information')) // eslint-disable-line no-console
delete argv.cov
}

await testCmd.run({
...argv,
bundle: false
Expand Down
Loading