Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gateway/blocks-backend: GetBlock should not perform IPLD decoding #845

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

gsergey418alt
Copy link
Contributor

Fixes #673.

@gsergey418alt gsergey418alt requested a review from lidel as a code owner February 14, 2025 11:01
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.51%. Comparing base (24b6bc3) to head (b76f2d0).

Files with missing lines Patch % Lines
gateway/backend_blocks.go 78.57% 2 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   60.37%   60.51%   +0.14%     
==========================================
  Files         243      244       +1     
  Lines       31119    31154      +35     
==========================================
+ Hits        18787    18853      +66     
+ Misses      10648    10623      -25     
+ Partials     1684     1678       -6     
Files with missing lines Coverage Δ
gateway/backend_blocks.go 46.16% <78.57%> (+0.60%) ⬆️

... and 12 files with indirect coverage changes

Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in kubo CI also. Looks good.

@gsergey418alt Thank you for this.

@gammazero gammazero merged commit 7c3ac0d into ipfs:main Feb 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gateway/blocks-backend: GetBlock should not perform IPLD decoding
3 participants