Skip to content

feat(gateway):dedicated error type for denylists #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

shobit000
Copy link

This pull request addresses issue #591 by introducing a dedicated error type for denylists in the IPFS gateway. The changes ensure that blocked content errors are properly conveyed using a specific error type instead of relying on string-based error checking.

Changes Made

  1. Introduced BlockedError type
  2. Updated isErrContentBlocked function
  3. Updated webError function

@shobit000 shobit000 requested a review from lidel as a code owner March 23, 2025 20:37
Copy link

welcome bot commented Mar 23, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shobit000 thank you for opening this, but was this generated with AI?

Same concerns as in

@lidel lidel added the need/author-input Needs input from the original author label Mar 24, 2025
@shobit000
Copy link
Author

yeag , used ai but will definately update you on my work on this pr

@gammazero
Copy link
Contributor

The information on the reason for being blocked needs to come from nopfs as it gives more context for the appropriate error to return. We need a solution that takes this into account. Closing, as this and not the way we want to solve this.

@gammazero gammazero closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants