Skip to content

gateway: validate against subdomains with IP addresses #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

gateway: validate against subdomains with IP addresses #903

merged 4 commits into from
Apr 8, 2025

Conversation

gitsrc
Copy link
Contributor

@gitsrc gitsrc commented Mar 28, 2025 •
edited
Loading

Prevent invalid configurations where UseSubdomains=true is set with IP addresses.

Changes:

  • Added validation in prepareHostnameGateways() to check for IP addresses when UseSubdomains is enabled
  • Invalid configurations are skipped with a warning log

#902

@gitsrc gitsrc requested review from lidel and a team as code owners March 28, 2025 11:03
@gammazero
Copy link
Contributor

Would you be able to write a test for this PR as well?

@gammazero gammazero added the need/author-input Needs input from the original author label Apr 1, 2025
@gitsrc
Copy link
Contributor Author

gitsrc commented Apr 5, 2025

Would you be able to write a test for this PR as well?

ok

@lidel lidel self-assigned this Apr 8, 2025
lidel
lidel reviewed Apr 8, 2025
View reviewed changes
lidel
lidel approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lidel lidel merged commit 8290f8c into ipfs:main Apr 8, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees

@lidel lidel

Labels
need/author-input Needs input from the original author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitsrc @gammazero @lidel