-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add t0123 ipns #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laurentsenta
commented
May 29, 2023
•
edited
Loading
edited
- build the test
- add a system to run 2 queries and compare the outputs
20 tasks
hacdias
reviewed
May 31, 2023
galargh
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm cool with proceeding with this as-is until we get more use cases for multi-request/multi-response setups.
Some ideas/thoughts I got looking at it:
- Should a test struct have both
Request
andRequests
prop on it? Could we get away with having one? - Do we want to limit duplication if parts of multiple requests are the same? As in, should we allow, for example,
Query
method on theRequestBuilder
list and have it set query for all the requests? - Similarly for the expects, would it be useful if we were able to do all the checks that we have on
ExpectBuilder
also onExpectsBuidlers
? - This one's a bit unrelated but would it make sense for
SugarTest
to be a builder as well?
Just wanted to dump ^ before I forget but no need to dig into it now.
Approving provided Henrique's comment is resolved ✅
hacdias
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.