Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github-mgmt stewards team with access to github-mgmt #37

Merged
merged 10 commits into from
Aug 5, 2022
Merged

Create github-mgmt stewards team with access to github-mgmt #37

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c19494
chore: create org-admins team with access to github-mgmt
galargh Aug 4, 2022
7648b4b
chore: update org-admins description
galargh Aug 4, 2022
f3b087d
chore: add comments on github-mgmt access setup
galargh Aug 5, 2022
e0aef7a
chore: clean up whitespace
galargh Aug 5, 2022
26bded2
fix: multiline github-mgmt codeowners definition
galargh Aug 5, 2022
84ad53e
Update github/ipfs.yml
galargh Aug 5, 2022
7b9c0da
chore: remove w3dt-stewards from github-mgmt
galargh Aug 5, 2022
9b34604
chore: rename org-admins to github-mgmt stewards to avoid confusion
galargh Aug 5, 2022
3cecf1d
fix: remove references to org-admins team
galargh Aug 5, 2022
8bca53f
Merge branch 'master' into org-admins
ipfs-mgmt-read-write[bot] Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions github/ipfs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,22 +750,28 @@ repositories:
- ipdx
visibility: public
github-mgmt:
# WARN: push+ access here should be treated exactly as cautiosly as org admin role
branch_protection:
master: {}
collaborators:
admin:
- galargh
files:
.github/workflows/stale.yml:
branch: master
content: .github/workflows/stale.yml
CODEOWNERS:
content: >
* @ipfs/ipdx
content: |
# The ipdx team is responsible for GitHub Management maintenance
* @ipfs/ipdx

# The org-admins team is responsible for triaging/reviewing configuration change requests
# TODO: uncomment once org-admins team has enough members
# /github/ipfs.yml @ipfs/org-admins
# ATTN: do not add teams with push+ access, use org-admins team membership instead
teams:
maintain:
- w3dt-stewards
- ipdx
push:
- org-admins
- w3dt-stewards # TODO: remove once org-admins team has enough members
visibility: public
go-bitfield:
collaborators:
Expand Down Expand Up @@ -4958,6 +4964,21 @@ teams:
- laurentsenta
parent_team_id: w3dt-stewards
privacy: closed
# NOTE: created to capture users with push+ access to github-mgmt repository
org-admins:
create_default_maintainer: false
description: Users that are effectively org admins
# WARN: membership here should be treated exactly as cautiosly as having an org admin role
# ATTN: members are expected to:
# - be familiar with GitHub Management
# - be ready to triage/review org configuration change request in github-mgmt
members:
maintainer:
- biglep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it so I am just a member so I too am forced to use github management?
We still have the escape hatch of true admins can use the UI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you're an actual org admin, then you're a maintainer of all the teams you belong to. GitHub API will happily accept a request to change your role to member but it doesn't really do anything and a subsequent query for your role will still return maintainer.

Same goes for Adin and Lidel so I moved them up here too.

member:
- aschmahmann
- willscott
privacy: closed
w3dt-stewards:
members:
maintainer:
Expand Down