fix: traverser should skip over identity CIDs #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and matching Lassie PR that uses and validates this: filecoin-project/lassie#426 (fails without this patch). |
|
UGH! This was supposed to be to boost-graphsync .. thanks GitHub UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is in ipldutil/traverser.go; without this, an identity CID in a DAG that contains a link to more blocks won't be properly traversed. Unsure how common this is in the real world, most identity CIDs are for chunks that are small enough that they can't fit a CID in but there are instances where people feel it worthwhile to inline chunks much larger than this (e.g.. The Filecoin chain itself has such inline CIDs too.
Matching go-graphsync PR.