Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download cid or ipfs path to fs (api changes) #2046

Closed
wants to merge 2 commits into from
Closed

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 18, 2022

Fixes #2021

License: MIT
Signed-off-by: Henrique Dias <[email protected]>
@hacdias hacdias requested a review from lidel March 18, 2022 13:08
@hacdias hacdias self-assigned this Mar 18, 2022
License: MIT
Signed-off-by: Henrique Dias <[email protected]>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to download /ipfs/bafybeig4vto32nvuhtbpy6tz3r4h6i5f3q45wnlouobfgymsrqyfptq3ru/10 - Pi Equals - transcript.txt (a file) and it saved it as bafybeiarcfttwercevqzdm2nyc2jo2m6i5ed22mutzypjozslfydx76m3i.tar with bafybeiarcfttwercevqzdm2nyc2jo2m6i5ed22mutzypjozslfydx76m3i blob inside – no file name was preserved.

I did the same tests for /ipfs/QmdmQXB2mzChmMeKY47C43LxUdg1NDJ5MWcKMKxDu7RgQm/10 - Pi Equals/ (a directory) and the contents of the directory were saved in QmdC5Hav9zdn2iS75reafXBq1PH4EnqUmoxwoxkS5QtuME.tar

Not sure how useful this feature is if we don't preserve filenames, and don't unpack from tar.
One can already download dir as a tar using ipfs-webui.

To keep codebase smaller, I am okay with removing this feature (no user complained that it was broken).

@hacdias
Copy link
Member Author

hacdias commented Mar 23, 2022

Superseeded by #2061

@hacdias hacdias closed this Mar 23, 2022
@hacdias hacdias deleted the fix/2021 branch March 23, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Download CID Not Working
2 participants