Staging #1684
Open
Staging #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds pre-commit linters
lidel
reviewed
Aug 28, 2023
| @@ -21,6 +21,9 @@ | |||
| "markdown-it-task-lists": "^2.1.1", | |||
| "markdown-it-video": "^0.6.3", | |||
| "prettier": "^3.0.2", | |||
| "markdown-link-check": "^3.11.2", | |||
| "markdownlint-cli2": "^0.8.1", | |||
| "pre-commit": "^1.2.2", | |||
There was a problem hiding this comment.
i've added "significantly" to one of markdown files to trigger one fo the rules, and then run npm ci && npm run md-lint and got this error:
----------------------------------------------------
Spelling and writing style check
----------------------------------------------------
pre-commit-lint.sh: line 35: pre-commit: command not found
@ElPaisano have no bandwidth to debug this, but I think pre-commit is too old (its been abandoned 7 years ago), so maybe remove it and use https://www.npmjs.com/package/husky instead?
|
test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk staging branch that merges: