-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dag-jose
decoder
#380
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Do you have an example CID we can use to test this out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but i’d love to get a CID to test to confirm
Let's also add tests to confirm things continue working properly |
@SgtPooki Sorry for the late response, been on vacation 🌴 Here is a public CID that I pulled from a cerscan stream you can try it out with: |
@SgtPooki I cannot find any existing tests in this package, so I'm not sure how I would go about doing that. |
@SgtPooki Thanks for the merge! Could you create a new release so I can PR an update to solve ipfs/ipfs-webui#1912? |
This PR adds support for using the
dag-jose
codec, useful viewing and traversing Ceramic Streams ⛓️Will solve this issue in
ipfs-webui
: ipfs/ipfs-webui#1912