Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hamt traversal in ipld-explorer ([email protected]) #10025

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: hamt traversal in ipld-explorer ([email protected]) #10025

merged 1 commit into from
Sep 5, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jul 25, 2023 •
edited by lidel
Loading

https://github.com/ipfs/ipfs-webui/releases/tag/v4.1.0

Includes fix for HAMT traversal bug in IPLD Explorer screen (ipld/explore.ipld.io#122)

@SgtPooki SgtPooki requested a review from lidel as a code owner July 25, 2023 22:29
@Jorropo
Copy link
Contributor

Jorropo commented Jul 25, 2023

anything worth adding to changelog ?

@SgtPooki
Copy link
Member Author

@Jorropo

  • new pinning service provider listed in the add pinning popup
  • new error message on fetch timeout on explore screen

@Jorropo
Copy link
Contributor

Jorropo commented Jul 25, 2023

Up to you, I would maybe add a link to webui's changelog inside kubo's changelog.
Else just add [skip changelog] to your PR 😉

@SgtPooki SgtPooki changed the title feat: [email protected] feat: [email protected] [skip changelog] Jul 27, 2023
@SgtPooki
Copy link
Member Author

modifying changelog for kubo is not something I think I will ever be doing since I have to pull down the whole repo and duplicate things.

@lidel lidel changed the title feat: [email protected] [skip changelog] fix: [email protected] Sep 5, 2023
@lidel lidel changed the title fix: [email protected] fix: hamt traversal in ipld-explorer ([email protected]) Sep 5, 2023
@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Sep 5, 2023
lidel
lidel approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, confirmed this includes fix for ipld/explore.ipld.io#122 so reclassifying as a fix PR 👍

Would be nice to include this in 0.23 (#10014)

@lidel lidel merged commit 0eeb1f5 into master Sep 5, 2023
20 of 22 checks passed
@lidel lidel deleted the SgtPooki-patch-1 branch September 5, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtPooki @Jorropo @lidel