Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zsh completions #10040

Merged
merged 5 commits into from
Aug 17, 2023
Merged

feat: add zsh completions #10040

merged 5 commits into from
Aug 17, 2023

Conversation

AmirMohammadFakhimi
Copy link
Contributor

@AmirMohammadFakhimi AmirMohammadFakhimi commented Jul 28, 2023

This PR is related to #8908 issue.

add zsh support
add zsh to doc

@AmirMohammadFakhimi AmirMohammadFakhimi requested a review from a team as a code owner July 28, 2023 15:06
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thx a lot ❤️, I don't use ZSH myself but this does not look to be malicious and if it's wrong I think someone would open an issue and tell us about it so that fine.

Could you please add tests like for example:

https://github.com/ipfs/kubo/blob/master/test/sharness/t0012-completion-fish.sh

I'll do that later if I have time to do it.

README.md Outdated Show resolved Hide resolved
@hacdias hacdias added the skip/changelog This change does NOT require a changelog entry label Aug 17, 2023
@hacdias hacdias changed the title Add zsh feat: add zsh completions Aug 17, 2023
@hacdias hacdias requested a review from Jorropo August 17, 2023 13:44
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally use zsh. I tested it locally and it worked. I added a test and cleaned up the documentation. Thanks for this!

@hacdias hacdias merged commit ced3483 into ipfs:master Aug 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants