-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add zikade DHT router #10154
feat: add zikade DHT router #10154
Conversation
config/routing.go
Outdated
@@ -106,6 +108,7 @@ type RouterType string | |||
const ( | |||
RouterTypeHTTP RouterType = "http" // HTTP JSON API for delegated routing systems (IPIP-337). | |||
RouterTypeDHT RouterType = "dht" // DHT router. | |||
RouterTypeDHTv2 RouterType = "dhtv2" // DHT router using go-libp2p-kad-dht/v2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this name is correct, this router is compatible with v1.
So I don't think v2 applies here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will allow different custom parameters, which I haven't added yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean network wise, it's just a different implementation, it's it will talk with other v1 dht servers and clients.
I would name it go-kademlia
The way I understand v2 here is that if I turn this I'm not part of the amino dht anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how this name could cause confusion between go-libp2p-kad-dht version 2 and version 2 of the dht protocols. I'll choose a better name - same for boxo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed router type to dht/zikade
Resubmit when/if ipfs/boxo#472 is merged |
Adds a
dht/zikade
routing type which corresponds to the refactored zikade DHT currently under development (previously go-libp2p-kad-dht/v2).Requires ipfs/boxo#472
This is intended as a future experimental routing method for Kubo.
Can be tested with configuration like this: