Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serve metrics correctly when there are multiple listeners #10489

Closed
wants to merge 5 commits into from
Closed

fix: serve metrics correctly when there are multiple listeners #10489

wants to merge 5 commits into from

Commits on Aug 21, 2024

  1. Fix errors with metrics when there are multiple listeners 

    When there are multiple listeners configured for Addresses.API, serving metrics results in an errors: "<metric> was collected before with the same name and label values".

This PR fixes this by maintaining a global map of metrics handlers, and only creating and reginstering them once. The same metrics handlers are provided to the mux for every listener.

Fixes #9891
Fixes #9397

Unblocks #9637
    @gammazero
    gammazero committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    dddc915 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'master' into fix/metrics_with_multiple_listeners

    @gammazero
    gammazero committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    34ecff1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/metrics_with_multiple_listeners

    @gammazero
    gammazero authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fcc8b48 View commit details
    Browse the repository at this point in the history

  3. Use consts for handler names

    @gammazero
    gammazero committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b506d46 View commit details
    Browse the repository at this point in the history

  4. save child mux

    @gammazero
    gammazero committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1c82a22 View commit details
    Browse the repository at this point in the history