Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pebbleds profile and plugin #10530

Merged
merged 13 commits into from
Oct 3, 2024
Merged

feat: pebbleds profile and plugin #10530

merged 13 commits into from
Oct 3, 2024

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented Oct 2, 2024

Pebble provides a high-performance alternative to leveldb as the datastore, and will serve as a replacement for badger1.

There are a number of tuning parameters available for tuning pebble's performance to your specific needs. Default values are used for any parameters that are not configured or are set to their zero-value.

Requires ipfs/go-ds-pebble#39

Closes #10347

Pebble provides a high-performance alternative to leveldb as the datastore, and will serve as a replacement for badger1.

There are a number of tuning parameters available for tuning pebble's performance to your specific needs. Default values are used for any that are not configured or are set to the parameter's zero-value.

Requires ipfs/go-ds-pebble#39

Closes #10347
@gammazero gammazero requested a review from a team as a code owner October 2, 2024 12:37
@gammazero gammazero requested a review from lidel October 2, 2024 17:12
@lidel lidel changed the title include pebble as built-in plugin feat: pebbleds profile and plugin Oct 2, 2024
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, pushed some extra docs and e2e test for all three datastore profiles

i think the only remaining topic here is if we should hardcode zero values in config – see the idea inline in init.go

config/init.go Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
config/init.go Show resolved Hide resolved
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's include it in 0.31.0-rc1 👍

go.mod Outdated
@@ -28,6 +29,7 @@ require (
github.com/ipfs/go-ds-flatfs v0.5.1
github.com/ipfs/go-ds-leveldb v0.5.0
github.com/ipfs/go-ds-measure v0.2.0
github.com/ipfs/go-ds-pebble v0.3.2-0.20241002075519-c174835dc84a
Copy link
Member

@lidel lidel Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gammazero mind releasing go-ds-pebble and switch to release here before merging this PR?

@lidel lidel mentioned this pull request Oct 3, 2024
34 tasks
@gammazero gammazero merged commit 52b0062 into master Oct 3, 2024
14 checks passed
@gammazero gammazero deleted the feat/support-pebble branch October 3, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pebble
2 participants