feat(routing/http): support IPIP-484 and streaming #10534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make requests with `filter-protocols` from IPIP-484 - define defaults and allow override via env for testing - prefer streaming responses
gammazero
approved these changes
Oct 3, 2024
|
Nice! Thanks for taking care of this |
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies IPIP-484 (cc @2color) protocol filtering to IPNI responses from
cid.contact/routing/v1/. It makes sure IPNI atcid.contactis queried with fix from ipfs/boxo#678 and we only ask for IPIP-484'sWithProtocolFilter("unknown","transport-bitswap")filter-protocolsfrom IPIP-484 (IPIP-484: Opt-in Filtering on Routing V1 HTTP API specs#484)cid.contactimplement backward-compatibility from https://specs.ipfs.tech/routing/http-routing-v1/#streaming and returns JSON instead of error