chore: update go-pinning-service-http-client #9140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit is only to see if sharness tests fror 'pin remote' pass
|
This never happened, and the client itself got moved to boxo: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is WIP, do not merge.
Context
We are planning changes to relax some requirements of pinning service API, and will have to re-generate client based on updated OpenAPI spec. We did it only once around v0.8.0, using
go-experimentalgenerator which got replaced bygoone, so doing it again requires additional refactoring and testing.Details in ipfs/go-pinning-service-http-client#19
TODO
go-pinning-service-http-client(generated using "stable" go generator) againstipfs pin remotetests we have in sharness