-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ipns): records with V2-only signatures #9932
Conversation
68fdeba
to
0a5140a
Compare
b0747a2
to
f6164e2
Compare
6bbf30e
to
e5ffac7
Compare
87ef459
to
07067dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Lgtm, but needs tests, probably in test/sharness/t0100-name.sh
(fine to add or migrate them to test/cli/harness
if you dont want to write bash)
-
ipfs name publish
+resolve
+inspect
with and withoutv1compat
b1a2c07
to
9a66425
Compare
3dc8fed
to
22dd4b9
Compare
22dd4b9
to
d5d3b91
Compare
5553fa2
to
49112b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some UX papercuts and missing tests need to be addressed (details below),
and needs to be rebased after ipfs/boxo#339 lands,
but otherwise lgtm.
@hacdias do you think we should include this in 0.21 (#9814), or do we do push both to 0.22? Since V2-only is opt-in, it should be safe to ship sooner, but ok to play it safe and push to 0.22
bda9a17
to
737c660
Compare
@lidel I addressed the feedback and merged on Boxo side. I will be merging here once CI passes. Regarding Kubo 0.21: I don’t mind either way. If we do an RC4 (let’s hope not), I will include it. Otherwise, let’s move it to Kubo 0.22. In case we don’t want to include it in Kubo 0.21 and there’s an RC4, I do not mind doing a cherry-picked release. For now, I will assume 0.22 - if we end up doing RC4, I will update the changelog accordingly. |
See ipfs/boxo#339.
boxo/ipns
. It wouldn't make sense to update it since it's deprecated (HTTP Router only uses Addresses.Swarm #9823 (comment)).