-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable hole punching and libp2p listener config #79
Conversation
this idoes not hurt, and should help if someone is runnign someguy without public addr + hole punching is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a good start. Though unlikely to help for the deployed delegated routing endpoints due to libp2p/go-libp2p#2913.
For the purposes of fixing the deployed delegated routing endpoints, we may want to allow passing a listen addr so that we can bind to a specific port (rather than the defaults which are randomly allocated) and open that port so that dialbacks work.
Suggested version: Changes in configuration file(s): (empty)
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
This PR proposes a patch release v0.4.1 that enables UPnP/hole punching bringing someguy closer to what Kubo does.
iiuc this does not hurt, and should help if someone is running someguy locally or behind some restrictive NAT without public addr + hole punching is necessary to reach other NATd peers