Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noaman/fixing GitHub actions #66

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Conversation

noamanahmed
Copy link
Contributor

This PR fixes the PHPUnit Compatibility issues and also generates code coverage reports in HTML.

Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one thing to fix

tests/IPinfoTest.php Outdated Show resolved Hide resolved
@UmanShahzad UmanShahzad merged commit 3fdf6b6 into master Sep 12, 2023
3 checks passed
@UmanShahzad UmanShahzad deleted the noaman/fixing_github_actions branch September 12, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants