Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process ad chain in segments during GC. #2460

Merged
merged 6 commits into from
Dec 29, 2023
Merged

Process ad chain in segments during GC. #2460

merged 6 commits into from
Dec 29, 2023

Conversation

gammazero
Copy link
Collaborator

If the amount of the ad chain to process is very long, then do not process all the ads at the same time. This may lead to keeping too many CIDs and context IDs in memory resulting in an out-of-memory condition. Instead process a segment of the chain at a time, starting from the oldest to the newest segment.

If the amount of the ad chain to process is very long, then do not process all the ads at the same time. This may lead to keeping too many CIDs and context IDs in memory resulting in an out-of-memory condition. Instead process a segment of the chain at a time, starting from the oldest to the newest segment.
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (4ee3e51) 47.06% compared to head (8d56ff9) 46.93%.
Report is 2 commits behind head on main.

Files Patch % Lines
ipni-gc/reaper/reaper.go 10.52% 80 Missing and 5 partials ⚠️
ipni-gc/reaper/option.go 14.28% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
- Coverage   47.06%   46.93%   -0.14%     
==========================================
  Files          85       85              
  Lines       10732    10737       +5     
==========================================
- Hits         5051     5039      -12     
- Misses       5080     5097      +17     
  Partials      601      601              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero changed the title Provess ad chain in segments during GC. Process ad chain in segments during GC. Dec 29, 2023
@gammazero gammazero merged commit 9b8261a into main Dec 29, 2023
9 checks passed
@gammazero gammazero deleted the gc-by-segment branch December 29, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants