feat: log if WithCAEndpoint(DefaultCATestEndpoint) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this implements idea from libp2p/go-libp2p#3103 (comment) to ensure users who set up staging endpoint for testing are always aware fo it and never ship it to production
2 tasks
2color
reviewed
Jan 9, 2025
2color
approved these changes
Jan 9, 2025
Co-authored-by: Daniel Norman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements idea from
libp2p/go-libp2p#3103 (comment) to ensure users who set up staging endpoint for testing are always aware of it and never ship test config to production.
Demo
Run p2p-forge/client
WithCAEndpoint(DefaultCATestEndpoint), it will log ERROR:2025-01-08T20:31:08.330+0100 ERROR example.autotls client/acme.go:245 initialized WithCAEndpoint(DefaultCATestEndpoint) (https://acme-staging-v02.api.letsencrypt.org/directory): certificate will be issued for staging purposes and won't work correctly in web browser; make sure to change to WithCAEndpoint(DefaultCAEndpoint) (https://acme-v02.api.letsencrypt.org/directory) before deploying to production or testing in web browser