Port RETURNDATALOAD from EIP-7069 PR #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
approved these changes
Jan 4, 2024
|
We should merge it like this for now, change later if needed. |
|
OK. Also ticked off on the open questions list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of last pending discussion items. The changes are ported directly from https://github.com/ethereum/EIPs/pull/7820/files, only with an update to the language to match the mega spec.
As I understand, this proposition should accompany the revamping of
*CALLinstructions, otherwise there might be code regressions (from Vyper team).There has been discussion on changing the RETURNDATA* semantics to pad with zero instead of halting on OOB, but this PR follows the EIP PR in keeping the (halt exceptionally) behavior. Unless there is a compelling reason to change to zero pad, I would keep it like that to not bloat the EOF change.