Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error introduced when merging relaxed stack valid. into megaspec #44

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix error introduced when merging relaxed stack valid. into megaspec #44

merged 1 commit into from
Jan 22, 2024

Conversation

pdobacz
Copy link
Member

@pdobacz pdobacz commented Jan 22, 2024

Otherwise, when CALLF is made and then JUMPF into a returning function, the expectation that CALLF results in a stack change of outputs - inputs is incorrect.

@pdobacz pdobacz marked this pull request as ready for review January 22, 2024 10:49
@pdobacz pdobacz mentioned this pull request Jan 22, 2024
Open
@pdobacz pdobacz requested review from chfast and removed request for chfast January 22, 2024 10:58
@pdobacz pdobacz self-assigned this Jan 22, 2024
@pdobacz pdobacz merged commit e6a7ede into main Jan 22, 2024
2 checks passed
@pdobacz pdobacz deleted the fix-jumpf-stack branch January 22, 2024 19:14
chfast
chfast reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast left review comments

@gumb0 gumb0 gumb0 approved these changes

Assignees

@pdobacz pdobacz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdobacz @chfast @gumb0