generalize truncated push opcodes test #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
chfast
merged commit 3d305f0
into
ipsilon:eof/migrate_opcode_validation
1 of 2 checks passed
pdobacz
pushed a commit
that referenced
this pull request
Nov 7, 2024
bug(tests) - CALLF rule #4 applies to return stack, not operand stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
I generalized the truncated push opcode test to test every opcode that has a data portion.
Also added an option to test with
max_stack_height==0or an approximation to what it should be if the opcode was interpreted correctly.