Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nested cross validation #169

Merged
merged 45 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
5507b4b
Messing around with refactoring model exploration
ccdavis Nov 14, 2024
3b84f26
Fixed failures due to bad code
ccdavis Nov 15, 2024
62ff6e6
No errors, use model exploration approach that should get pr_auc mean…
ccdavis Nov 15, 2024
3477b71
remove cache() and typo
ccdavis Nov 15, 2024
c0397c5
Renaming for clarity
ccdavis Nov 16, 2024
1fe6224
wip
Nov 16, 2024
28c6cde
giving up for now
ccdavis Nov 16, 2024
1f70f66
wip
ccdavis Nov 18, 2024
8e5415f
refactoring
ccdavis Nov 19, 2024
941bd06
finished refactoring sketch
ccdavis Nov 19, 2024
1f2bd49
Fixed some typos
ccdavis Nov 19, 2024
21cac61
correctly save suspicious data
ccdavis Nov 19, 2024
c9576e8
Debugging _get_aggregates in test. It looks like the test data just d…
ccdavis Nov 20, 2024
319129f
Use all splits on thresholding
Nov 15, 2024
9a90143
Adjust test to account for results with only the best hyper parameter…
ccdavis Nov 21, 2024
a14ccdf
Clean up stdout and make a model-param selection report.
ccdavis Nov 21, 2024
2facf41
model exploration tests pass; need more
ccdavis Nov 21, 2024
3bbac41
Separate each fold test run output.
Nov 22, 2024
3b22f14
Clean up output
ccdavis Nov 25, 2024
efa67f7
Tests pass
ccdavis Nov 25, 2024
38c1006
fixed some tests, the FNS count test is broken because of the single …
ccdavis Nov 25, 2024
a94250c
wip
ccdavis Nov 27, 2024
667d322
Possibly working nested cv
Nov 22, 2024
f4a42f7
fix typo, testing
ccdavis Dec 2, 2024
761e38f
reformatted
Dec 2, 2024
3e0cb90
better output for tracking progress of train-test
Dec 2, 2024
c7e7ba2
better messages
Dec 2, 2024
fdd402c
Better logging
ccdavis Dec 3, 2024
3500e7c
correctly group threshold metrics by outer fold iteration.
ccdavis Dec 3, 2024
1ea05d0
Try fewer shuffle partitions
ccdavis Dec 3, 2024
10ab7b4
set shuffle partitions back to 200
ccdavis Dec 3, 2024
47e28a6
Added nested-cv algo description in comments.
ccdavis Dec 3, 2024
b5e128f
Added seed on inner fold splitter; Update tests to at least pass.
ccdavis Dec 3, 2024
b123dbf
assert the logistic regression gives a decent result
ccdavis Dec 3, 2024
1ead1e7
Temporary commented out asserts due to different results presentation…
ccdavis Dec 3, 2024
45f3649
another test passes
ccdavis Dec 3, 2024
40f075d
all tests should pass
ccdavis Dec 3, 2024
02bc77c
Allow manually running CI/CD via on: workflow_dispatch
riley-harper Dec 3, 2024
37e3a57
Merge pull request #170 from ipums/manual_ci_trigger
riley-harper Dec 3, 2024
b9c2123
fixed quote indent
ccdavis Dec 3, 2024
40f344e
Merge branch 'main' into refactor-nested-cross-validation
ccdavis Dec 3, 2024
6370eda
Run CI/CD on all PRs, not just PRs to main
riley-harper Dec 3, 2024
71c4fea
Merge pull request #171 from ipums/ci_on_all_prs
riley-harper Dec 3, 2024
1e55384
Address PR comments
ccdavis Dec 3, 2024
02d5f96
Merge branch 'main' into refactor-nested-cross-validation
ccdavis Dec 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ on:
branches:
- main
pull_request:
branches:
- main
workflow_dispatch:

env:
HLINK_TAG: hlink:githubactions
Expand Down
Loading
Loading