Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] ipykernel 7 support #898

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:
- name: Install Python dependencies
run: |
pip install --pre --upgrade ipyparallel[test]
pip install --pre --upgrade ipyparallel[test] 'https://github.com/minrk/ipykernel/archive/parallel.tar.gz#egg=ipykernel'
- name: Install extra Python packages
if: ${{ ! startsWith(matrix.python, '3.11') }}
Expand Down
4 changes: 4 additions & 0 deletions ipyparallel/cluster/launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,10 @@ async def join(self, timeout=None):
"""Wait for the process to exit"""
if self._wait_thread is not None:
self._wait_thread.join(timeout=timeout)
if self._wait_thread.is_alive():
raise TimeoutError(
f"Process {self.process.pid} did not exit in {timeout} seconds."
)

def _stream_file(self, path):
"""Stream one file"""
Expand Down
Loading
Loading