Fix #13445: keep CPython 3.10+ suggestion hints in IPython tracebacks #15008
+109
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauricioharley
force-pushed
the
address_issue_13445
branch
from
5f716dd to
22a1d5b
Compare
* Reuses traceback.format_exception_only when formatting exceptions so the CPython 3.10+ “Did you mean …” hints requested in ipython#13445 appear in IPython output. * Accepts the real exception type, keep multi-line suggestion lines, and still append any PEP-678 notes for the message. * Adds helper-driven regression tests that compare IPython’s traceback output against CPython for attribute/name errors on Python ≥3.10. Fixes ipython#13445 Signed-off-by: Mauricio Harley <[email protected]>
mauricioharley
force-pushed
the
address_issue_13445
branch
from
22a1d5b to
637493b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13445