Add GPT-2 GGML x86 and Android Benchmarks #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariecwhite
force-pushed
the
ggml-android
branch
30 times, most recently
from
6faec99 to
40e7cf9
Compare
mariecwhite
force-pushed
the
ggml-android
branch
18 times, most recently
from
974bdbe to
d94f0e0
Compare
mariecwhite
commented
Sep 11, 2023
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: |
There was a problem hiding this comment.
Remove before merging
pzread
approved these changes
Sep 11, 2023
| ./experimental/ggml/benchmark_ggml.sh "${TARGET_DEVICE}" "${GGML_BUILD_DIR}" "${RESULTS_PATH}" | ||
| cat "${RESULTS_PATH}" | ||
|
|
||
| # adb push "./experimental/ggml/set_android_scaling_governor.sh" "/data/local/tmp" |
There was a problem hiding this comment.
Can you add a comment to explain the reason these lines are commented out?
There was a problem hiding this comment.
I was supposed to remove all of this! Removed.
| }, | ||
| ) | ||
|
|
||
| ALL_DEVICES = [MOBILE_PIXEL_6_PRO] |
experimental/ggml/benchmark_ggml.sh
Outdated
| set -xeuo pipefail | ||
|
|
||
| VENV_DIR="${OOBI_VENV_DIR:-ggml-benchmarks.venv}" | ||
| PYTHON="${PYTHON:-/usr/bin/python3}" |
There was a problem hiding this comment.
This might work in broader environments
Suggested change
| PYTHON="${PYTHON:-/usr/bin/python3}" | |
| PYTHON="${PYTHON:-"$(which python3)"}" |
There was a problem hiding this comment.
Thanks, changed.
experimental/ggml/benchmark_ggml.sh
Outdated
| ) | ||
|
|
||
| if [[ "${TARGET_DEVICE_NAME}" =~ ^(pixel-4|pixel-6-pro|moto-edge-x30)$ ]]; then | ||
| BENCHMARK_SCRIPT="run_benchmarks_android.py" |
There was a problem hiding this comment.
nit: Maybe have one indent as these are in a if block? Same on the else block
| @@ -0,0 +1,51 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # Copyright 2023 The IREE Authors | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2023 The IREE Authors | |
| # Copyright 2023 The OpenXLA Authors |
mariecwhite
force-pushed
the
ggml-android
branch
from
d94f0e0 to
cc48e0b
Compare
pzread
approved these changes
Sep 11, 2023
mariecwhite
force-pushed
the
ggml-android
branch
from
cc48e0b to
55d152a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes F32, F16 and INT4 versions.