Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JAX and TFLite Models #166

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

mariecwhite
Copy link
Collaborator

There have been some recent changes to StableHLO that requires regeneration of JAX and TFLite models. TF model generation is currently broken due to version skews across HuggingFace, TF, and Keras.

@mariecwhite mariecwhite marked this pull request as ready for review February 4, 2024 21:59
@mariecwhite mariecwhite requested a review from pzread February 4, 2024 21:59
@mariecwhite
Copy link
Collaborator Author

Comparative benchmarks is failing due to a compiler error in openxla/xla, not due to these changes.

@@ -13,6 +13,7 @@ on:
schedule:
# Scheduled to run at 09:00 UTC and 21:00 UTC.
- cron: '0 09,21 * * *'
pull_request:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder of removal

@@ -248,7 +248,7 @@ jobs:
run: |
RESULTS_PATH="${RESULTS_DIR}/${JAX_IREE_RESULTS_JSON}"
docker run --mount="type=bind,src="${PWD}",target=/work" --workdir="/work" \
"gcr.io/iree-oss/openxla-benchmark/base-python3.10@sha256:245a074284cfed5de60cf06a153e3bcd9a9c42702b6bb66a39bb47ef23b61669" \
"gcr.io/gcr.io/iree-oss/openxla-benchmark/base-python3.11@sha256:b9b98da7bcc5e431800ff798a6dcc394b1838a9ed3d695f5cd0dac3510fc8c8d" \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcr.io/gcr.io/iree-oss/ -> gcr.io/iree-oss/?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh thank you for catching this!

@mariecwhite mariecwhite merged commit 418cb9e into iree-org:main Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants