Iterators: Create accumulate op as "asymmetric" version of reduce #618
+534
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
iterators-accumulate
branch
from
42e50cb to
e38524b
Compare
ingomueller-net
force-pushed
the
iterators-accumulate
branch
from
e38524b to
fca969e
Compare
ingomueller-net
force-pushed
the
iterators-accumulate
branch
2 times, most recently
from
e19b44d to
4430e6e
Compare
ingomueller-net
force-pushed
the
iterators-accumulate
branch
2 times, most recently
from
9e267f2 to
7dd926a
Compare
ingomueller-net
force-pushed
the
iterators-accumulate
branch
2 times, most recently
from
fa7a37d to
d49ed91
Compare
ingomueller-net
force-pushed
the
iterators-accumulate
branch
from
d49ed91 to
8466965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
AccumulateOpas an asymmetric version ofReduceOp. The two ops are similar, and we should discuss whether it makes sense to keep both, but accumulate as implemented in this PR allows to do things that reduce doesn't, for example, to "accumulate" elements into a container:accumulate(container, element): container.insert(element). In the current version of reduce, we force the signature to be(T, T) -> T, whereas accumulate allows for(T1, T2) -> T1(which, at the same time, requires the definition of an empty accumulator value).