Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

Commit

Permalink
Fix grammar in README.
Browse files Browse the repository at this point in the history 
Also, explain a couple more benefits of the native training example.
  • Loading branch information
@dellis23
dellis23 authored Dec 12, 2022
1 parent 6a6f60b commit 5fbaf50
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ An end-to-end example of compiling an `nn.Module`-based PyTorch BERT model to IR

## Native, On-device Training

A small, self-contained binary can be built for deploying to resource-constrained environments can be found in [this example](https://github.com/iree-org/iree-torch/tree/main/examples/native_training).
A small (~100-250KB), self-contained binary can be built for deploying to resource-constrained environments. An example illustrating this can be found in [this example](https://github.com/iree-org/iree-torch/tree/main/examples/native_training). This binary runs a model without a Python interpreter.

# Planned features

Expand Down

4 comments on commit 5fbaf50

@LiqinWeng
Copy link

@LiqinWeng LiqinWeng commented on 5fbaf50 Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exec this command : ninja -C "${IREE_BUILD_ROOT}" IREECompilerPythonModules bindings_python_iree_runtime_runtime
will report error as flows:
image
could you fix it?
@dellis23

@dellis23
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exec this command : ninja -C "${IREE_BUILD_ROOT}" IREECompilerPythonModules bindings_python_iree_runtime_runtime will report error as flows: image could you fix it? @dellis23

I'd like to help, but I think the best I'd be able to do is to try to direct you to the right place to file an issue. Where did you find the command you're trying to run? Somewhere in iree? You might want to file an issue there and document which setup steps you were following.

@LiqinWeng
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to help, but I think the best I'd be able to do is to try to direct you to the right place to file an issue. Where did you find the command you're trying to run? Somewhere in iree? You might want to file an issue there and document which setup steps you were following.

sorry, I will send the problem to issue in the future. The command from iree-torch/README.md， the step of Running end-to-end correctness tests , so I think the README.md need update.

@dellis23
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to help, but I think the best I'd be able to do is to try to direct you to the right place to file an issue. Where did you find the command you're trying to run? Somewhere in iree? You might want to file an issue there and document which setup steps you were following.

sorry, I will send the problem to issue in the future. The command from iree-torch/README.md， the step of Running end-to-end correctness tests , so I think the README.md need update.

Ah, I see, thank you! I didn't realize that was in our readme. I should have looked harder. This is indeed a good place to file the issue. I will do that for you.

Please sign in to comment.