Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests][aot] Add test for externalized parameters #202

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
0327398
Reorder iter args to match ordering of init args and outputs (#161)
harsh-nod Sep 24, 2024
4e95351
[ExportedProgram] Add mutable attribute to buffer (#123)
chrsmcgrr Sep 24, 2024
65eb532
[TKW] Add xfail decorator for unaligned shape (#163)
raikonenfnu Sep 24, 2024
909411a
[TKW] Fix indexing of Reduction and GetResult to enable post-tile op.…
raikonenfnu Sep 24, 2024
d37c6a4
Get GEMMs working without minimize_global_loads (#167)
harsh-nod Sep 26, 2024
04a4ba5
Add first draft of introduction (#168)
harsh-nod Sep 26, 2024
7686157
[TKW] igemm shared mem tests (#171)
Hardcode84 Sep 26, 2024
0e16d54
[TKW] Implement support for multiple iter args on Reduction (#166)
raikonenfnu Sep 27, 2024
192a786
Handle complex element type in torch.vtensor conversion (#175)
sogartar Sep 27, 2024
92ad900
[TKW] Rework vector mask generation (#172)
Hardcode84 Sep 30, 2024
621cbe1
Enable import_symbolic_shape_expressions in the FxImporter. (#179)
stellaraccident Sep 30, 2024
84320ea
Add code to construct pipelined loop from schedule (#160)
harsh-nod Oct 1, 2024
553e929
Add support for dynamic dims (#178)
harsh-nod Oct 1, 2024
9ed388a
[TKW] Fix sympy expr lowering and add some more igemm test shapes (#184)
Hardcode84 Oct 3, 2024
0f00c6d
Add benchmark support for e2e tests (#183)
erman-gurses Oct 3, 2024
e0a8fdf
[TKW] Thread Shape analysis (#186)
raikonenfnu Oct 3, 2024
d98e521
Disable benchmarking on all e2e tests for now (#189)
harsh-nod Oct 3, 2024
a04ea80
Set `fail-fast: false` (#190)
Hardcode84 Oct 3, 2024
207efd9
[TKW] IGEMM Benchmarking (#187)
Hardcode84 Oct 4, 2024
64b7d27
[TKW] Update IR interpreter (#182)
Hardcode84 Oct 4, 2024
7617c94
[TKW] Implement broadcastOp class, lowering and insertion (#176)
raikonenfnu Oct 4, 2024
83bbc40
Add ability to dump intermediates (#194)
harsh-nod Oct 4, 2024
39acab8
Split TK CI from main CI (#195)
Hardcode84 Oct 4, 2024
4fec47c
Add parameterization for benchmark flag (#192)
erman-gurses Oct 4, 2024
da3436d
Add padding to reduce shared memory bank conflicts (#193)
harsh-nod Oct 4, 2024
b0ef345
Rename `shark-turbine` -> `iree.turbine` (#197)
Hardcode84 Oct 5, 2024
796f3a5
[TKW] Minor bug fix expansion to handle reduction and MMA at same tim…
raikonenfnu Oct 5, 2024
47720f2
[tests][aot] Add test for externalized parameters
vinayakdsci Oct 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TKW] Add xfail decorator for unaligned shape (#163)
  • Loading branch information
raikonenfnu authored Sep 24, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 65eb532abb2acec0b95b66565b35352579a7d896
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -60,7 +60,6 @@ jobs:
if: "contains(matrix.os, 'mi300') && !cancelled()"
run: |
export WAVE_RUN_E2E_TESTS=1
export TEST_PARAMS_PATH=./tests/kernel/wave/test_param.json
pytest -n 4 ./tests/kernel/wave/

- name: Run LIT tests
13 changes: 12 additions & 1 deletion tests/kernel/wave/wave_e2e_test.py
Original file line number Diff line number Diff line change
@@ -44,6 +44,15 @@ def get_test_shapes(test_name: str) -> list[tuple[int]]:
return default_test_shapes


def xfail_unaligned(func):
def wrapper(shape):
if shape[-1] % 2 != 0:
pytest.xfail("Unaligned shape is not expected to work on this test yet.")
func(shape)

return wrapper


@require_e2e
@pytest.mark.parametrize("shape", get_test_shapes("test_copy"))
def test_copy(shape):
@@ -269,13 +278,14 @@ def test(

@require_e2e
@pytest.mark.parametrize("shape", get_test_shapes("test_tiled_reduce_max"))
@xfail_unaligned
def test_tiled_reduce_max(shape):
M = tkl.sym.M
N = tkl.sym.N
wave_size = 64
BLOCK_M = 1
BLOCK_N = tkl.sym.BLOCK_N
ELEMS_PER_THREAD = BLOCK_N / wave_size
ELEMS_PER_THREAD = tkl.sym.ELEMS_PER_THREAD
ADDRESS_SPACE = tkl.sym.ADDRESS_SPACE

constraints: list[tkw.Constraint] = [
@@ -322,6 +332,7 @@ def repeat(
M: shape[0],
N: shape[1],
BLOCK_N: min(128, shape[1]),
ELEMS_PER_THREAD: min(128, shape[1]) // wave_size,
ADDRESS_SPACE: tkl.AddressSpace.GLOBAL_MEMORY.value,
},
canonicalize=True,