Added readme to the aot_mlp example #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Verma <[email protected]> Signed-off-by: xintin <[email protected]>
xintin
force-pushed
the
xintin/added_readme_aot_mlp
branch
from
f44920b to
34f2379
Compare
ScottTodd
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
The pre-commit link checks found a few minor style issues in this file and the README: https://github.com/iree-org/iree-turbine/actions/runs/11811883913/job/33237529472?pr=266
If you could fix those, that would be great. A maintainer could also push those fixes for you.
| @@ -0,0 +1,4 @@ | |||
| numpy | |||
| torch | |||
There was a problem hiding this comment.
Might want to suggest https://github.com/iree-org/iree-turbine/tree/main?tab=readme-ov-file#install-pytorch-for-your-system for some users rather than the stock torch requirement, at least as a note in the README ahead of the pip install -r requirements.txt. Installing the CPU torch wheel is much faster than the default (that includes tons of CUDA deps).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following main changes:
aot_mlpexample.equirements.txtfor theaot_mlpexample.README.mdfile for theaot_mlpexample.