[Encoding] Introduce "layouts" field to EncodingAttr. #19215
Conversation
The revisions introduces a new attribute interface in the Encoding dialect. The interface is used to query layout information needed to materialize encoding attributes. Any backend can implement the interface to interpret an encoding layout based on their needs. The current expectation of the interface is to propagate layout information from backends to the host compliation or other targets. The expectation can be adjusted as long as we identify additional needs for encodings/layouts. It is a step towards iree-org#17924 Signed-off-by: hanhanW <[email protected]>
| OptionalParameter<"ArrayAttr", "An array of attributes that describes the " | ||
| "potential layouts on the device. It is an array because a device could " | ||
| "have several executable targets. Note that it can be any attribute with " | ||
| "encoding attribute interface implementation. The expectation of the field " |
There was a problem hiding this comment.
I should probably rebase this on top of #19216, so I can explicitly use the EncodingLayoutAttrInterface term here. Does it sound better?
There was a problem hiding this comment.
I do fell like it will be great to combine the two (or rebase one on top of the other) and review them all together. The reason being one about the design and one is about implementation/application, so they share context.
There was a problem hiding this comment.
Let me rebase this on top of the other one. The PRs look relevant, but honestly I don't know how to write PR title and description if we combine them all together. I agree that the code is in a weird stage because there are no actual users. I should be able to add some unittests in upcoming PRs once I have them landed.
hanhanW
force-pushed
the
encoding-targets
branch
from
fb09133
to
982ea05
Compare
|
rebased and updated the comment, please review the last commit. |
The revision introduces an optional "layouts" field to EncodingAttr. It is an array of attributes that describes the potential layouts on the device. It is an array because a device could have several executable targets. Note that it can be any attribute with encoding attribute interface implementation. The expectation of the field is to bridge the logics between host codes and device codes. If an attribute does not implement the interface, it could be discarded anytime. It is a step towards iree-org#17924 Signed-off-by: hanhanW <[email protected]>
hanhanW
force-pushed
the
encoding-targets
branch
from
982ea05
to
c69bc93
Compare
The revision introduces an optional "layouts" field to EncodingAttr. It is an array of attributes that describes the potential layouts on the device. It is an array because a device could have several executable targets. Note that it can be any attribute that implements EncodingLayoutAttrInterface. The expectation of the field is to bridge the logics between host codes and device codes. If an attribute does not implement the interface, it could be discarded anytime.
The revision also updates the TODO item for
round_dims_tofield. Because IREE is going to use the new "layouts" field and upcoming attribute interface to handle the allocation problem.It is a step towards #17924