-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Encoding] Introduce EncodingLayoutAttrInterface. #19216
Open
hanhanW
wants to merge
1
commit into
iree-org:main
Choose a base branch
from
hanhanW:encoding-attr-interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingInterfaces.td
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright 2024 The IREE Authors | ||
| // | ||
| // Licensed under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #ifndef IREE_DIALECT_ENCODING_INTERFACES | ||
| #define IREE_DIALECT_ENCODING_INTERFACES | ||
|
|
||
| include "iree/compiler/Dialect/Encoding/IR/EncodingBase.td" | ||
| include "mlir/IR/BuiltinAttributeInterfaces.td" | ||
|
|
||
| def IREEEncoding_EncodingLayoutAttrInterface : | ||
| AttrInterface<"EncodingLayoutAttrInterface"> { | ||
| let cppNamespace = "::mlir::iree_compiler::IREE::Encoding"; | ||
| let description = [{ | ||
| Interface used to query layout information needed to materialize encoding | ||
| attributes. | ||
|
|
||
| Any backend can implement the interface to interpret an encoding layout | ||
| based on their needs. | ||
|
|
||
| TBD. The current expectation of the interface is to propagate layout | ||
| information from backends to the host compliation or other targets. | ||
| }]; | ||
|
|
||
| let methods = [ | ||
| InterfaceMethod< | ||
| /*desc=*/[{ | ||
| Returns the storage size (in bytes) for the tensor types with an | ||
| optional encoding. | ||
| }], | ||
| /*retTy=*/"::mlir::OpFoldResult", | ||
| /*methodName=*/"calculateStorageSizeInBytes", | ||
| /*args=*/(ins | ||
| "::mlir::OpBuilder &":$builder, | ||
| "RankedTensorType":$type, | ||
| "ValueRange":$dynamicDims | ||
| ), | ||
| /*methodBody=*/"", | ||
| /*defaultImplementation=*/[{ | ||
| return {}; | ||
| }] | ||
| > | ||
| ]; | ||
| } | ||
|
|
||
| #endif // IREE_DIALECT_ENCODING_INTERFACES | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to insert an assert to fail here? I assume it must be re-implemented by whoever inherits the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do it. The other way to think about it is that the caller can check if the return value is nullptr or not; raise the error with proper messages. Adding an assertion is being careful to me, while it could add confusion to users because the error messages and stack dump are all bad. Both work for me because we do not have a working case today..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a user I would definitely prefer not to check null every time I call this function, if such API call guarantees that it will definitely return something sensible other than nullptr.