[i1] Implement packed_storage layout encoding attribute
#19354
+93
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lialan
changed the title
i1_packed_storage layout encoding attributepacked_storage layout encoding attribute
lialan
force-pushed
the
lialan/i1_attr
branch
3 times, most recently
from
1f2e200 to
8588cfd
Compare
lialan
requested review from
hanhanW,
MaheshRavishankar,
IanWood1,
bjacob and
benvanik
as code owners
lialan
force-pushed
the
lialan/i1_attr
branch
from
ed80669 to
bac621f
Compare
* make `packed_storage` as a type of `iree_encoding` attribute, and make type converters accept it. * `i1` tensors with `#iree_encoding.packed_storage` will be interpreted as packed i1 type, same as specifying `--iree-experimental-packed-i1-storage`. * `--iree-experimental-packed-i1-storage` are kept for testing purposes. We can drop this option after frontend enables emitting `i1` tensors with attributes. Signed-off-by: Alan Li <[email protected]>
lialan
force-pushed
the
lialan/i1_attr
branch
from
bac621f to
349a6bd
Compare
lialan
changed the title
packed_storage layout encoding attributepacked_storage layout encoding attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packed_storageas a type ofiree_encodingattribute, and make type converters accept it.i1tensors with#iree_encoding.packed_storagewill be interpreted as packed i1 type, same as specifying--iree-experimental-packed-i1-storage. Other i1 tensors are treated as non-packed datatype, and will be extended.--iree-experimental-packed-i1-storageare kept for testing purposes.i1tensors with attributes.