[Dispatch] Fold collapse(expand)
unit dims
#19357
Open
+256
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fold unit dimensions for the pattern
collapse(expand)
by removing any unnecessary unit dims that are expanded out and subsequently collapsed again. This prevents the collapse/expand ops, which contain unneeded unit dims, from being propagated and introducing unit dims back to linalg ops.Doesn't quite resolve #19263 because there are
flow.tensor.bitcast
ops that are preventing the unit dims from being completely folded: