Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dispatch] Don't fuse bit truncate -> extend ops #19407

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

[Dispatch] Don't fuse bit truncate -> extend ops #19407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/DispatchCreation/ElementwiseOpFusion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ void ElementwiseOpFusionPass::runOnOperation() {
};

RewritePatternSet linalgFusionPatterns(context);
linalgFusionPatterns.insert<GatherFusionPattern>(context);
linalg::populateElementwiseOpsFusionPatterns(linalgFusionPatterns,
fuseElementwiseOpsControlFn);

Expand All @@ -158,7 +159,6 @@ void ElementwiseOpFusionPass::runOnOperation() {
RewritePatternSet linalgExtFusionPatterns(context);
IREE::LinalgExt::populateFuseLinalgExtOpsWithTransposes(
linalgExtFusionPatterns, foldTransposeControlFn);
linalgExtFusionPatterns.insert<GatherFusionPattern>(context);
if (failed(applyPatternsAndFoldGreedily(
getOperation(), std::move(linalgExtFusionPatterns), rewriteConfig))) {
getOperation()->emitOpError(
Expand Down
4 changes: 3 additions & 1 deletion compiler/src/iree/compiler/DispatchCreation/FusionUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ bool areFusableAsElementwiseOps(MLIRContext *context, OpOperand *fusedOperand,
// (except for bit-extend ops). If the consumer has only one use, then this
// fusion is fine since cloning wont result in redundant computation of the
// producer. (Also note that the producer is always an elementwise operation).
if (IREE::LinalgExt::isBitExtendOp(consumerOp) && !consumerOp->hasOneUse()) {
if (IREE::LinalgExt::isBitExtendOp(consumerOp) &&
(!consumerOp->hasOneUse() ||
IREE::LinalgExt::isBitTruncateOp(producerOp))) {
return false;
}

Expand Down
Loading