[LinalgExt] Drop the unit dims on scatter ops #19450
Draft
+126
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds patterns to drop the unit dims of a
iree_linalg_ext.scatter
's%updates
tensor. Changes were also made to the verifier to allow forscatter
to not have unit dims. For example, the following would be illegal because theupdates
tensor has too small of a rank:See the related issue #19091