Add relative error for buffer comparison #19464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nirvedh <[email protected]>
nirvedhmeshram
force-pushed
the
add_relative_error
branch
from
2b83a99 to
0fe398b
Compare
benvanik
requested changes
Dec 11, 2024
benvanik
reviewed
Dec 11, 2024
Signed-off-by: Nirvedh <[email protected]>
Signed-off-by: Nirvedh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large values using relative error for buffer comparison can be helpful as shown by the
CompareElementwiseF16NearEQRelativetest