-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh project status in README and website homepage. #19482
Conversation
ScottTodd
commented
Dec 13, 2024
•
edited
Loading
edited
- Replace "IREE is still in its early phase." language with information about IREE being a sandbox project at the LF AI & Data Foundation.
- Link to release notes via the non-prerelease releases page since the standard https://github.com/iree-org/iree/releases page is littered with nightly releases. Grouping prereleases under a single release like in iree-turbine and other projects would help here too.
- Format "Presentations and talks" section with a table. We've had a few talks that aren't yet included here and the community meetings are now split between YouTube and Zoom (LF AI) ... not sure how best to organize them.
- Add more icons to https://iree.dev/ homepage and expand on sections:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a few comments but nothing that prevents merging as is.
All stable (non-prerelease) releases can be viewed at | ||
<https://github.com/iree-org/iree/releases?q=prerelease%3Afalse>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All stable (non-prerelease) releases can be viewed at | |
<https://github.com/iree-org/iree/releases?q=prerelease%3Afalse>. | |
All stable (non-prerelease) releases can be viewed at GitHub | |
[releases page](https://github.com/iree-org/iree/releases?q=prerelease%3Afalse). |
?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(fixed the suggestion syntax in your comment)
For this developer page I want to spell out the URL, query parameters and all. In the README I have it hidden under some nicer text:
### Release status
Releases notes are
[published on GitHub releases](https://github.com/iree-org/iree/releases?q=prerelease%3Afalse).
If we switch this repo to using a "dev-wheels" style release for multiple nightly releases to append assets to then we can switch both back to the base https://github.com/iree-org/iree/releases, since the daily pre-releases won't be spammed
@@ -159,7 +159,7 @@ runtime entirely or interface with custom accelerators. | |||
IREE supports the full set of these configurations using the same underlying | |||
technology. | |||
|
|||
### Compiling models | |||
### :octicons-file-code-24: Compiling models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should get :octicons-rocket-24:
🚀 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was going for consistency with these
### :octicons-file-code-16: Compile a program |
### :octicons-file-code-16: Compile a program |
(but with 24
instead of 16
on the homepage... I liked the 16px icons on subpages but 24px felt better here 🤷 https://primer.style/foundations/icons)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the previous section uses the rocket icon already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this wasn't supposed to be a serious comment ;)
Co-authored-by: Marius Brehler <[email protected]>
Possibly broken by updating past https://github.com/squidfunk/mkdocs-material/releases/tag/9.5.34 in #19482. > Updated Mermaid.js to version 11 (latest) ## API diagrams Broken: ![image](https://github.com/user-attachments/assets/c2caff21-6f32-4ecc-a0fe-7f6eef1f980b) Fixed: ![image](https://github.com/user-attachments/assets/57e92506-62a8-4b69-8752-1642120c9e24) ## Concepts diagram Before: ![image](https://github.com/user-attachments/assets/72fb7bdc-bc1c-470e-b0cc-19df37f77a4c) Current (broken): ![image](https://github.com/user-attachments/assets/022eff49-6f11-41e9-8cd8-29564540f13b) Fixed: ![image](https://github.com/user-attachments/assets/76d0da19-a52a-49fa-a209-5653a124839e)