Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep-Type Dictionaries #142

Merged
merged 6 commits into from
Apr 27, 2024
Merged

Deep-Type Dictionaries #142

merged 6 commits into from
Apr 27, 2024

Conversation

gordonwatts
Copy link
Member

@gordonwatts gordonwatts commented Apr 26, 2024

  • Created dictionaries are assigned to a data-class
  • Data class is correctly typed
  • Data class is de-referenced as needed.

This is only done during type resolution. The hope is this will not affect any other part of the work flow.

Help working towards idap 200 test.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.93%. Comparing base (8612740) to head (b0c1b8f).

Files Patch % Lines
func_adl/type_based_replacement.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   96.97%   96.93%   -0.05%     
==========================================
  Files          15       15              
  Lines        1324     1336      +12     
==========================================
+ Hits         1284     1295      +11     
- Misses         40       41       +1     
Flag Coverage Δ
unittests 96.93% <92.30%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gordonwatts gordonwatts self-assigned this Apr 27, 2024
@gordonwatts gordonwatts added the bug Something isn't working label Apr 27, 2024
@gordonwatts gordonwatts merged commit 5f23cfb into master Apr 27, 2024
49 checks passed
@gordonwatts gordonwatts deleted the pr_dict_as_dataclass branch April 27, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants