Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Support Python 3.9+ #159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matthewfeickert
Copy link
Member

Resolves #158

  • Require Python 3.9+, dropping support for Python 3.7 and 3.8 as both are EOL, and Python 3.8+ syntax is already being used in the current release which already EOLs 3.7.
  • Update minimum Python used in CI to 3.9.

There are stil Python 3.7 specific notes in the code:

$ git grep "3\.7"
func_adl/ast/function_simplifier.py:442:        # Get the value out - this is due to supporting python 3.7-3.9
func_adl/ast/function_simplifier.py:567:    """Deal with 3.7, and 3.8 differences in how indexing for list and tuple
func_adl/type_based_replacement.py:946:            "3.7 compatibility"
func_adl/type_based_replacement.py:951:            "3.7 compatibility"
func_adl/type_based_replacement.py:956:            "3.7 compatibility"
func_adl/util_types.py:25:    * This works for 3.7 forward (but not back!)

but I don't know enough about func-adl internals to be able to edit these quickly, so I'll need @gordonwatts or @masonproffitt to look at that.

@matthewfeickert matthewfeickert force-pushed the build/support-python-39-plus branch from c52bde4 to 350fcb1 Compare December 31, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.7 as already invalidated by Python 3.8 syntax
1 participant