Remove legacy ast support (pre 3.9) #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 96.92% 97.27% +0.34%
==========================================
Files 15 15
Lines 1334 1319 -15
==========================================
- Hits 1293 1283 -10
+ Misses 41 36 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 9, 2025
gordonwatts
added a commit
that referenced
this pull request
Mar 10, 2025
* Remove ast.Num * Remove ast.Str * Remove ast.NameConstant * Move to value for constant * Remove ast.Index as well * Fix up pylance errors due to `ast.expr` * Fix up a few flake8 import errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer supporting Python 3.7, a lot of legacy code can be removed. This will be required anyway as we move to python 3.14 where a lot of this stuff simply disappears.
ast.Numsupportast.Strsupportast.NameConstantsupportast.exprto remove lots ofcastoperations.Fixes #171