WhisperNode - remove deprecated channels #76
Conversation
Removing chains/channels that WhisperNode no longer validates or relays packets for. Signed-off-by: ghost // WhisperNode <[email protected]>
WalkthroughThe changes involve the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
relayers/WhisperNode/relayer_info.json (1)
Line range hint
1-124: LGTM! Consider adding a comment for removed chains.The changes align well with the PR objectives. Deprecated chains and channels have been successfully removed from the
addressesarray, streamlining the relayer information.To improve documentation:
Consider adding a comment at the end of the file to list the removed chains. This can help track changes over time and provide context for future updates. For example:
], "_removed_chains": [ "archway-1", "mantle-1", "comdex-1", "juno-1" // Add other removed chains here ] }This addition is optional but can be helpful for maintaining a history of supported chains.
🧰 Tools
🪛 Gitleaks
105-105: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
113-113: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
120-120: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- relayers/WhisperNode/relayer_info.json (1 hunks)
🔇 Additional comments (1)
relayers/WhisperNode/relayer_info.json (1)
Line range hint
1-124: Verify removal of deprecated chainsThe changes appear to be correct and consistent with the PR objectives. No unintended modifications to team information, contact details, or the remaining address entries are observed.
To ensure all deprecated chains have been removed and no active chains were accidentally deleted, please run the following script:
For future updates, consider maintaining a separate configuration file listing all supported chains. This would make it easier to track changes and ensure consistency across updates.
✅ Verification successful
Additional Verification Needed
To ensure that all deprecated chains have been successfully removed and no active chains were accidentally deleted, please run the following scripts:
Verification Successful
All deprecated chains have been successfully removed, and no active chains were accidentally deleted. The JSON structure is valid and consistent with the PR objectives.
- Deprecated chains removed:
archway-1,mantle-1,comdex-1,juno-1- Active chains verified: All listed active chains are present and correctly configured.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify removed chains and ensure no active chains were accidentally deleted # Test: List all unique chain IDs in the current file echo "Current chain IDs:" jq -r '.addresses | map(keys[]) | unique | .[]' relayers/WhisperNode/relayer_info.json | sort # Test: Compare with a list of known active chains (replace with your actual list) echo -e "\nVerify that all these chains are still present:" echo "akashnet-2 axelar-dojo-1 canine-1 cheqd-mainnet-1 cosmoshub-4 injective-1 neutron-1 osmosis-1 secret-4 stride-1" # Test: Check for any mentions of removed chains in the file echo -e "\nCheck for any remaining mentions of removed chains:" grep -E "archway-1|mantle-1|comdex-1|juno-1" relayers/WhisperNode/relayer_info.jsonLength of output: 803
Script:
#!/bin/bash # Description: Cross-validate current chains against a list of deprecated chains # Define deprecated chains deprecated_chains=("archway-1" "mantle-1" "comdex-1" "juno-1") # List current chain IDs current_chains=$(jq -r '.addresses | map(keys[]) | unique | .[]' relayers/WhisperNode/relayer_info.json) # Check for any deprecated chains in the current chains echo "Checking for deprecated chains in current chain IDs..." for chain in "${deprecated_chains[@]}"; do if echo "$current_chains" | grep -qw "$chain"; then echo "Deprecated chain found: $chain" fi done # Confirm JSON structure validity echo -e "\nValidating JSON structure..." jq empty relayers/WhisperNode/relayer_info.json && echo "JSON structure is valid." || echo "JSON structure is invalid."Length of output: 1313
Script:
#!/bin/bash # Description: Verify presence of all active chains # Define active chains active_chains=("akashnet-2" "axelar-dojo-1" "canine-1" "cheqd-mainnet-1" "cosmoshub-4" "injective-1" "neutron-1" "osmosis-1" "secret-4" "stride-1") # List current chain IDs current_chains=$(jq -r '.addresses | map(keys[]) | unique | .[]' relayers/WhisperNode/relayer_info.json) # Check for missing active chains echo "Verifying all active chains are present..." for chain in "${active_chains[@]}"; do if ! echo "$current_chains" | grep -qw "$chain"; then echo "Missing active chain: $chain" fi doneLength of output: 2267
🧰 Tools
🪛 Gitleaks
105-105: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
113-113: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
120-120: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Removing chains/channels that WhisperNode no longer validates or relays packets for.
Summary by CodeRabbit
New Features
Bug Fixes