Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#299] Update changelog (main) #304

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[#299] Update changelog (main) #304

merged 1 commit into from
Oct 11, 2024

Conversation

korydraughn
Copy link
Contributor

No description provided.

@korydraughn korydraughn requested review from trel and alanking October 10, 2024 21:07
CHANGELOG.md Outdated Show resolved Hide resolved
@korydraughn
Copy link
Contributor Author

Issue number 180 is the General Housekeeping issue. Seems fine to reference multiple times.

Thoughts?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@trel
Copy link
Member

trel commented Oct 11, 2024

i think this is good for squashing. we can release tomorrow.

@korydraughn
Copy link
Contributor Author

Squashed.

Will pound after the version bump PR is merged.

Copy link
Collaborator

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes themselves look good. Had one thought regarding the changelog adherence comment, but it's not a big deal

CHANGELOG.md Show resolved Hide resolved
@korydraughn
Copy link
Contributor Author

Pounded.

@alanking alanking merged commit 585aa74 into irods:main Oct 11, 2024
@korydraughn korydraughn deleted the 299.m branch October 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants