Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[535] Implement basic support for GenQuery2 #555

Merged
merged 1 commit into from
May 17, 2024
Merged

[535] Implement basic support for GenQuery2 #555

merged 1 commit into from
May 17, 2024

Conversation

stsnel
Copy link
Collaborator

@stsnel stsnel commented May 13, 2024

Here's a draft for an initial version of GenQuery2 support (issue 535)

@stsnel stsnel force-pushed the add-basic-genquery2-support branch from ff51694 to 352ef9c Compare May 13, 2024 11:29
@korydraughn
Copy link
Contributor

Thanks for the contribution. We'll review and share our thoughts.

alanking
alanking reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few suggestions/comments. I would have suggested adding more tests, but the existing tests basically exercise the interface in this client, so I don't think it would add anything beyond just testing the API (which we do plenty of in the main repo).

Nice work!

irods/query2.py Outdated Show resolved Hide resolved
irods/query2.py Outdated Show resolved Hide resolved
irods/query2.py Outdated Show resolved Hide resolved
irods/session.py Outdated Show resolved Hide resolved
irods/test/query2_test.py Outdated Show resolved Hide resolved
irods/test/query2_test.py Outdated Show resolved Hide resolved
@stsnel stsnel force-pushed the add-basic-genquery2-support branch from 352ef9c to e239307 Compare May 14, 2024 19:03
@stsnel
Copy link
Collaborator Author

stsnel commented May 14, 2024

I had a few suggestions/comments. I would have suggested adding more tests, but the existing tests basically exercise the interface in this client, so I don't think it would add anything beyond just testing the API (which we do plenty of in the main repo).

Nice work!

Thank you for the feedback!

korydraughn
korydraughn reviewed May 14, 2024
View reviewed changes
irods/genquery2.py Outdated Show resolved Hide resolved
irods/genquery2.py Outdated Show resolved Hide resolved
irods/genquery2.py Outdated Show resolved Hide resolved
korydraughn
korydraughn reviewed May 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@stsnel stsnel force-pushed the add-basic-genquery2-support branch 3 times, most recently from dac3a60 to cb8230d Compare May 16, 2024 14:18
korydraughn
korydraughn approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Let's get an approval from @alanking and @d-w-moore before adding the pound.

alanking
alanking approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's make sure @d-w-moore is okay with it and I think we'll be good to go.

@alanking alanking mentioned this pull request May 16, 2024
Closed
@korydraughn korydraughn requested a review from d-w-moore May 16, 2024 21:53
d-w-moore
d-w-moore approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@d-w-moore d-w-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@stsnel stsnel force-pushed the add-basic-genquery2-support branch from cb8230d to 6b67b98 Compare May 17, 2024 05:46
@alanking alanking merged commit 71d787f into irods:main May 17, 2024
1 check passed
@alanking alanking mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanking alanking alanking approved these changes

@d-w-moore d-w-moore d-w-moore approved these changes

@korydraughn korydraughn korydraughn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stsnel @korydraughn @alanking @d-w-moore