Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#556] implement library features #593

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[#556] implement library features #593

merged 1 commit into from
Aug 1, 2024

Conversation

d-w-moore
Copy link
Collaborator

See #556

@d-w-moore d-w-moore marked this pull request as draft July 24, 2024 11:03
alanking
alanking reviewed Jul 29, 2024
View reviewed changes
irods/exception.py Show resolved Hide resolved
irods/test/library_features_test.py Outdated Show resolved Hide resolved
irods/library_features.py Outdated Show resolved Hide resolved
@d-w-moore d-w-moore marked this pull request as ready for review July 30, 2024 22:44
alanking
alanking reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ready for squash?

korydraughn
korydraughn reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@d-w-moore
Copy link
Collaborator Author

Done, squashed in a trivial codacy correction and rebased onto upstream/main as well.

alanking
alanking approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please await one more approval before #s

trel
trel reviewed Aug 1, 2024
View reviewed changes
irods/exception.py Outdated Show resolved Hide resolved
korydraughn
korydraughn reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the extra space, it looks good.

Please take care of that and squash it, no pounds.

irods/session.py Outdated Show resolved Hide resolved
@trel
Copy link
Member

trel commented Aug 1, 2024

please update this commit to point to 533, as it's the older of the two duplicate issues.

alanking
alanking approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. # it

@alanking alanking merged commit 3015e40 into irods:main Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn left review comments

@trel trel trel left review comments

@alanking alanking alanking approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-w-moore @trel @korydraughn @alanking