Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#517] allow generating a pam-password based .irodsA if not pre-existing #620

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

d-w-moore
Copy link
Collaborator

Capability for PRC to generate a PAM-based .irodsA authentication file, as iinit does when pam_password is the authentication scheme.

irods/client_init.py Outdated Show resolved Hide resolved
@korydraughn
Copy link
Contributor

Will review once PR is out of draft.

@d-w-moore d-w-moore marked this pull request as ready for review September 26, 2024 16:20
irods/test/scripts/test002.bats Outdated Show resolved Hide resolved
irods/test/scripts/test002.bats Outdated Show resolved Hide resolved
irods/test/scripts/test002.bats Outdated Show resolved Hide resolved
irods/test/scripts/test002.bats Outdated Show resolved Hide resolved
irods/test/scripts/test002.bats Outdated Show resolved Hide resolved
irods/test/scripts/test003.bats Outdated Show resolved Hide resolved
@korydraughn
Copy link
Contributor

Seems I was missing part of the commit during the review.

Looking at other (modified) files now.

@d-w-moore
Copy link
Collaborator Author

Seems I was missing part of the commit during the review.

Looking at other (modified) files now.

Wondering if you were referring to the docker test implementation itself, which has been put off to a 3.0+ milestone. If this is confusing, I could defer inclusion of the actual tests to a later pull request.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
irods/client_init.py Outdated Show resolved Hide resolved
@korydraughn
Copy link
Contributor

Wondering if you were referring to the docker test implementation itself, which has been put off to a 3.0+ milestone. If this is confusing, I could defer inclusion of the actual tests to a later pull request.

I think the GitHub notification only showed me the latest changes and I failed to think about changes that could have been made prior to that.

It's fine, I've looked at the other files and left comments.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very helpful for theoretical and non-theoretical future projects :)

irods/__init__.py Show resolved Hide resolved
irods/session.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
irods/client_init.py Outdated Show resolved Hide resolved
irods/__init__.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@alanking
Copy link
Contributor

alanking commented Oct 7, 2024

Please resolve review conversations as things are addressed, if appropriate. Also, take a peek at some of those Codacy issues and see if there's anything in need of addressing in your view. Thanks

@d-w-moore
Copy link
Collaborator Author

Please resolve review conversations as things are addressed, if appropriate. Also, take a peek at some of those Codacy issues and see if there's anything in need of addressing in your view. Thanks

Yes, will do

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I think it's ready for squashing, but let's wait for one more vote before doing so just in case there are other review comments.

Oh, and unresolved conversations. Forgot about that.

@d-w-moore
Copy link
Collaborator Author

Seems fine to me. I think it's ready for squashing, but let's wait for one more vote before doing so just in case there are other review comments.

Oh, and unresolved conversations. Forgot about that.

Still working on the conversations and final testing, so don't worry. No rush.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me. No open conversations, I think. Please await thoughts from others before The Squash

README.md Outdated Show resolved Hide resolved
@korydraughn
Copy link
Contributor

Please squash.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

… native authentication.

This commit introduces iinit-like capability to generate the .irodsA file, when not
previously existing, for the pam_password authentication scheme.  Also, free functions
are introduced which create the .irodsA file from a cleartext password value in the native and
pam_password authentication schemes.
@alanking alanking merged commit dcd6c13 into irods:main Oct 11, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants