-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#517] allow generating a pam-password based .irodsA if not pre-existing #620
Conversation
Will review once PR is out of draft. |
Seems I was missing part of the commit during the review. Looking at other (modified) files now. |
Wondering if you were referring to the docker test implementation itself, which has been put off to a 3.0+ milestone. If this is confusing, I could defer inclusion of the actual tests to a later pull request. |
I think the GitHub notification only showed me the latest changes and I failed to think about changes that could have been made prior to that. It's fine, I've looked at the other files and left comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be very helpful for theoretical and non-theoretical future projects :)
Please resolve review conversations as things are addressed, if appropriate. Also, take a peek at some of those Codacy issues and see if there's anything in need of addressing in your view. Thanks |
Yes, will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. I think it's ready for squashing, but let's wait for one more vote before doing so just in case there are other review comments.
Oh, and unresolved conversations. Forgot about that.
Still working on the conversations and final testing, so don't worry. No rush. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good to me. No open conversations, I think. Please await thoughts from others before The Squash
Please squash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pound it.
… native authentication. This commit introduces iinit-like capability to generate the .irodsA file, when not previously existing, for the pam_password authentication scheme. Also, free functions are introduced which create the .irodsA file from a cleartext password value in the native and pam_password authentication schemes.
Capability for PRC to generate a PAM-based .irodsA authentication file, as iinit does when pam_password is the authentication scheme.